feat(lint): add avoid_async_emit rule with tests and documentation

[Katekko]

Status

READY

Breaking Changes

NO

Description

• feat(bloc_lint): avoid_async_emit (closes feat(bloc_lint): avoid_async_emit #4490)

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore

[Katekko]

Hello @felangel

I've implemented the avoid_async_emit lint rule based on the open issue regarding unguarded emit calls inside async methods. This rule helps ensure emit is properly guarded with isClosed checks to prevent potential runtime issues. Please review and let me know if any adjustments are needed!

ps. This is my first time contributing a lint rule. Please let me know if there are any improvements I can make or if there's a better approach I should follow.

[felangel]

Thanks so much for the PR! I haven't thoroughly reviewed the code yet but at first glance I think changes are needed since this lint rule should apply to both Bloc and Cubit instances. Currently it looks like this is implemented to ignore Bloc instances entirely.

[Katekko]

You were right—I needed to include Bloc as well. I updated the condition in handleIdentifier to check for both Cubit and Bloc tokens. Thanks for pointing it out!

[codecov]

Codecov Report

❌ Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ages/bloc_lint/lib/src/rules/avoid_async_emit.dart	98.64%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[euclidesgc]

You were right—I needed to include Bloc as well. I updated the condition in handleIdentifier to check for both Cubit and Bloc tokens. Thanks for pointing it out!

Great job, bro, you were amazing.
This will help us get the benefits much sooner than we expected. I'm proud of you, and thanks so much for your contribution to this process. I can't wait to use it.

[felangel]

Just wanted to say this is still very much on my radar -- I need to get #4562 merged first and then this is next on my list to review and get merged. Thanks so much for taking the time to contribution! 💙

[felangel]

Sorry for the delay! This is next on my todo list and I'm hoping to get this reviewed and merged in the next few days.

[euclidesgc]

Sorry for the delay! This is next on my todo list and I'm hoping to get this reviewed and merged in the next few days.

Hey man, how's it going? Do you have any idea when this awesome feature will be merged?

[felangel]

Sorry for the delay! This is next on my todo list and I'm hoping to get this reviewed and merged in the next few days.

Hey man, how's it going? Do you have any idea when this awesome feature will be merged?

Sorry for the delay! Hoping to have some time this week to clean this up and get it landed but at first glance I don't think it's ready to land as-is.