fix(hydrated_bloc): serialize non-string map keys#4758
Merged
felangel merged 14 commits intofelangel:masterfrom Mar 14, 2026
Merged
fix(hydrated_bloc): serialize non-string map keys#4758felangel merged 14 commits intofelangel:masterfrom
felangel merged 14 commits intofelangel:masterfrom
Conversation
…of dropping them When using json_serializable with @jsonvalue(int) enums as map keys, _traverseComplexJson silently dropped entries because _cast<String>(key) returned null for non-String keys. This converts them via toString() instead, consistent with _traverseRead behavior. Closes felangel#3983
felangel
added
bug
felangel
changed the title
felangel
previously approved these changes
Mar 14, 2026
Owner
felangel
left a comment
felangel
left a comment
There was a problem hiding this comment.
LGTM thanks so much for the contribution! 💙
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_traverseComplexJsonsilently dropping map entries with non-String keys (e.g. int keys from@JsonValue(int)enums used as map keys injson_serializable)._cast<String>(key)returningnullfor non-String keys, causing entries to be skipped entirely. Replaced withkey is String ? key : key?.toString(), consistent with how_traverseReadalready handles keys.Closes #3983
Test plan
@JsonValue(int)enum-like map keysdart analyzeclean (no errors or warnings)