Add searchable timezone combobox#72
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Pull request overview
Introduces a shared, searchable timezone combobox (built with cmdk + Popover) and replaces existing timezone selects across the create flow and event heatmap surfaces, with i18n copy and unit test updates.
Changes:
- Added a reusable
TimezoneComboboxcomponent and acmdk-basedCommandUI wrapper. - Replaced existing timezone
Selectusage in the create event form and event heatmap viewer timezone control. - Added i18n strings for search placeholder/empty state and updated tests to cover filtering + selection.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/i18n/messages.ts | Adds i18n strings for timezone search placeholder + empty state (EN/DE). |
| src/components/ui/command.tsx | Adds cmdk-based command primitives used by the combobox. |
| src/components/timezone-combobox.tsx | Implements the shared searchable timezone combobox with filtering and “automatic timezone” support. |
| src/components/event-heatmap.tsx | Replaces viewer timezone Select with TimezoneCombobox. |
| src/components/create-event-form.tsx | Replaces event timezone Select with TimezoneCombobox, preserving invalid/description wiring. |
| src/components/create-event-form.test.tsx | Adds coverage for filtering timezone options and keeping the selected value. |
| src/components/public-event-client.test.tsx | Updates tests to exercise search filtering behavior in the public flow. |
| src/components/manage-event-client.test.tsx | Updates tests to exercise search filtering behavior in the organizer/manage flow. |
| package.json | Adds cmdk dependency. |
| pnpm-lock.yaml | Locks cmdk dependency resolution. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
cmdkandPopover.Testing
pnpm verifypassed, including the full test suite, Prisma generation, and production build.