Skip to content

Add searchable timezone combobox#72

Merged
felixgollnhuber merged 2 commits intomainfrom
codex/timezone-text-search
Apr 29, 2026
Merged

Add searchable timezone combobox#72
felixgollnhuber merged 2 commits intomainfrom
codex/timezone-text-search

Conversation

@felixgollnhuber
Copy link
Copy Markdown
Owner

Summary

  • Replaced the timezone selects with a shared searchable combobox based on cmdk and Popover.
  • Applied the new control to the create flow, public event view, and organizer manage view.
  • Added search placeholder and empty-state copy to i18n and kept timezone sorting unchanged.

Testing

  • Added unit tests covering timezone search filtering and selection in the create, public, and manage flows.
  • pnpm verify passed, including the full test suite, Prisma generation, and production build.

Copilot AI review requested due to automatic review settings April 29, 2026 11:42
@felixgollnhuber
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a shared, searchable timezone combobox (built with cmdk + Popover) and replaces existing timezone selects across the create flow and event heatmap surfaces, with i18n copy and unit test updates.

Changes:

  • Added a reusable TimezoneCombobox component and a cmdk-based Command UI wrapper.
  • Replaced existing timezone Select usage in the create event form and event heatmap viewer timezone control.
  • Added i18n strings for search placeholder/empty state and updated tests to cover filtering + selection.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/lib/i18n/messages.ts Adds i18n strings for timezone search placeholder + empty state (EN/DE).
src/components/ui/command.tsx Adds cmdk-based command primitives used by the combobox.
src/components/timezone-combobox.tsx Implements the shared searchable timezone combobox with filtering and “automatic timezone” support.
src/components/event-heatmap.tsx Replaces viewer timezone Select with TimezoneCombobox.
src/components/create-event-form.tsx Replaces event timezone Select with TimezoneCombobox, preserving invalid/description wiring.
src/components/create-event-form.test.tsx Adds coverage for filtering timezone options and keeping the selected value.
src/components/public-event-client.test.tsx Updates tests to exercise search filtering behavior in the public flow.
src/components/manage-event-client.test.tsx Updates tests to exercise search filtering behavior in the organizer/manage flow.
package.json Adds cmdk dependency.
pnpm-lock.yaml Locks cmdk dependency resolution.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/ui/command.tsx
Comment thread src/components/ui/command.tsx Outdated
@felixgollnhuber felixgollnhuber merged commit f5a0d83 into main Apr 29, 2026
2 checks passed
@felixgollnhuber felixgollnhuber deleted the codex/timezone-text-search branch April 29, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants