Skip to content

Conversation

@astim1
Copy link
Contributor

@astim1 astim1 commented Dec 19, 2025

Converted assign_TASK4_DDFs() from R to python and added a test script for it in tests.

The test required me to convert most of section 3a of Main(), as well as a couple other attribute maps earlier in the script, from R to python, so this could be used when time comes to implement that part of the main function in python.

Copy link

@rroyall-stantec rroyall-stantec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest rather than declaring a bunch of work inside the actual test function, look into pytest fixtures and use that to set up the input values instead. Technically we should be using fixtures for reusable code blocks and input variables for tests but it also allows us to not pollute the test function itself with tons of setup code that isn't doing any actual testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants