ci: Drop Wikibase from the selenium stage#221
Merged
Conversation
Quibble's selenium stage runs `npm run selenium-test` for every dependency that defines it. On REL1_43, Wikibase's wdio config globs in the wikibase-termbox selenium specs, which render a mobile UI that needs MinervaNeue + MobileFrontend; without them waitForTermboxToLoad times out, so the selenium check failed on flaky termbox specs that have nothing to do with this extension. Wikimedia's own CI does not run Wikibase's selenium for downstream extensions either (its master selenium-test entry is gated to a no-op). Mirror that: drop Wikibase from the selenium stage's dependency set only; it stays for phan/phpunit, which need it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 5.59% 5.59%
Complexity 46 46
=======================================
Files 4 4
Lines 143 143
=======================================
Hits 8 8
Misses 135 135 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
seleniumrequired check has been failing on Wikibase's bundledwikibase-termboxselenium specs (reading/editing/LicenseOverlay.spec.js), which time out inwaitForTermboxToLoad.Root cause (confirmed against Wikimedia CI): Quibble's selenium stage runs
npm run selenium-testfor every dependency that defines it. On REL1_43, Wikibase's wdio config globs in the termbox specs, whose mobile UI needs MinervaNeue + MobileFrontend to render (it is client-side-rendered; the SSR service is unrelated). Without them the page never hydrates and the specs time out. None of this exercises this extension.Wikimedia's own CI does not run Wikibase's selenium for downstream extensions (on master Wikibase gates its
selenium-testscript to a no-op; only REL1_43 lacks that gate). This mirrors that: drop Wikibase from the selenium stage's dependency set only. Wikibase stays forphan/phpunit, which need it.Expected result: the selenium check goes green legitimately, so the repo no longer needs admin-merge overrides.