perf: remove clipped modifier #328
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisIsTheFoxe
suggested changes
Feb 3, 2025
There was a problem hiding this comment.
Thanks, nice idea and an issue we're currently facing as well..
However, as also suggested in #325 I think it'd be best to make this user configurable.
Also, by removing the clipping w/o warning it might break some projects.
So, I'd suggest making it configurable and keeping it clipped by default. That way we could roll this change out as a minor version update, rather than it being a breaking change.. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I found that the ignoreSafeArea page content is clipped. I think it's better that let the framework users determine whether clip the page content.