Skip to content

feat: update FDR definition to include support for float types. #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 43 commits into
base: app
Choose a base branch
from

Conversation

eyw520
Copy link
Member

@eyw520 eyw520 commented Feb 19, 2025

Short description of the changes made

Include support for float types in FDR types.

What was the motivation & context behind this PR?

Deepgram wanted it.

How has this PR been tested?

RohinBhargava and others added 30 commits February 7, 2025 04:19
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Darwin Ding <[email protected]>
Co-authored-by: Kapil Gowru <[email protected]>
Co-authored-by: Kapil Gowru <[email protected]>
Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Feb 19, 2025 6:06pm

@eyw520 eyw520 had a problem deploying to Preview - app.buildwithfern.com February 19, 2025 18:06 — with GitHub Actions Failure
@eyw520 eyw520 had a problem deploying to Preview - app-dev.buildwithfern.com February 19, 2025 18:06 — with GitHub Actions Failure
Copy link

@RohinBhargava
Copy link
Contributor

Can you try running this with docs:dev? I have a feeling the UI won't know how to handle the float type appropriately. take a peek at the changes made under fern-docs here: https://github.com/fern-api/fern-platform/pull/1981/files#diff-e54066586263ce78b8063ee953d47d6fadbf4750490b7a9b1d147d1597197455

@dsinghvi dsinghvi changed the base branch from main to app April 6, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants