Skip to content

Conversation

@patrickthornton
Copy link
Contributor

Description

QueryValuesWithDefaults used to panic when receiving a nil input, but doesn't now.

Changes Made

This change also does some considerable Go as-is file maintenance:

  1. Moves almost all of the remaining as-is files to v2 generation and deleting them in v1 (so it shouldn't be confusing where to make edits for most of these files now).
  2. Deletes the go/internal/testdata snapshots, which appear to be indicative of an old snapshot testing routine now outmoded by seed.
  3. Standardizes to the use of any over the use of interface{} in as-is files.

Testing

Added a small extra test to query_test.go to test nil inputs; plus seed.

@github-actions
Copy link

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI
  • Postman

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants