fix(typescript): prevent undefined in pagination item type paths #10757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the TypeScript SDK generator where pagination endpoints with optional response containers would generate invalid type signatures like
undefined.List.Item.Link to Devin run: https://app.devin.ai/sessions/64d3e6a952544a91a61aa47698a37441
Requested by: [email protected] (@tjb9dc)
Problem
When generating pagination return types for endpoints where the items array is nested under an optional property (e.g.,
response.data?.listwheredatais optional), the generator would produce invalid TypeScript:The issue occurred because
getReferenceToResponsePropertyType()was converting a union type node likeListTelephonyResponse.Data | undefinedto a string, then appending.List.Item, resulting inundefined.List.Item.Changes Made
removeUndefinedAndNullFromTypeNodeutilityTypeContextImpl.getReferenceToResponsePropertyType()to stripundefinedandnullfrom type nodes before converting to strings for inline property type name constructionListTelephonyResponse.Data.List.Itemare built correctly without union types in the middleTesting
Recommended review steps:
Page._getReferenceToTypehas similar issuesRisk Assessment