Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

Description

Refs https://buildwithfern.slack.com/archives/C05J55L8JES/p1763673405911359

Fixes a bug where the selfHosted flag in the IR was always false even when Venus returns selfHostedSDKs: true for an organization. This was causing issues with README generation for organizations like Bloomberg that have self-hosted SDKs enabled.

Changes Made

  • Added propagation of selfHosted flag from Venus organization data to IR in local generation path (runLocalGenerationForWorkspace.ts)
  • Added propagation of selfHosted flag from Venus organization data to IR in remote generation path (runRemoteGenerationForGenerator.ts)
  • Follows the same pattern as the existing whiteLabel flag propagation

Root Cause

The IR was hardcoded with selfHosted: false in generateIntermediateRepresentation(), and even though the Venus API returns organization data with selfHostedSDKs, this value was never being used to update the IR after generation.

Testing

  • Lint checks passed (pnpm run check)
  • Manual testing with an organization that has selfHostedSDKs: true (e.g., Bloomberg) - Reviewer should verify this works as expected

Review Checklist

  • Verify the field name selfHostedSdKs matches the Venus SDK type definition (it's the TypeScript field name that maps to wire format selfHostedSDKs)
  • Confirm this change is consistent with how whiteLabel flag is propagated (same pattern, same location)
  • Check if there are other generation paths that might need updating (I searched and found only these two main paths)
  • Verify that generators actually use ir.selfHosted for README generation or other purposes (TypeScript generator confirmed to use it)

Link to Devin run: https://app.devin.ai/sessions/dde07ad03651451a95658926abd372a1
Requested by: [email protected] (@aditya-arolkar-swe)

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant