chore(seed): remove stale go-sdk exhaustive:omit-empty-request-wrappers allowedFailure

[iamnamananand996]

Description

Part of the one-by-one effort to clear go-sdk allowedFailures.

exhaustive:omit-empty-request-wrappers is a stale allowed failure — it passes. It only appeared to fail in local seed runs because of a Docker container-name collision, not a generator bug.

Root cause: both exhaustive configs (no-custom-config and omit-empty-request-wrappers) spin up a WireMock container named wiremock-exhaustive-wiremock-1 (derived from the fixture name exhaustive). When the two configs run concurrently in a single local seed test invocation, the second docker compose up fails with:

Container wiremock-exhaustive-wiremock-1 ... Conflict. The container name
"/wiremock-exhaustive-wiremock-1" is already in use ...

Whichever config wins the race runs its wire tests for ~40s and passes; the loser fails fast (~1s). In CI the two configs run in separate matrix jobs, so there is no collision and both pass.

Changes Made

• Removed exhaustive:omit-empty-request-wrappers from allowedFailures in seed/go-sdk/seed.yml.
• No generator code change required (hence no changelog entry).

Testing

• Ran the fixture in isolation (--outputFolder omit-empty-request-wrappers) 3x — passes every time (wire tests ~40s). Seed CLI reports: "1/1 test cases succeeded unexpectedly. Consider removing the following fixtures from allowedFailures: exhaustive:omit-empty-request-wrappers."
• Confirmed the only reason for the prior local failure is the shared WireMock container name when both configs run together.
• Relying on CI seed-test-results (go-sdk) to confirm green with the entry removed.

Link to Devin session: https://app.devin.ai/sessions/6ba63e4405694aa8ab8875f0dbfd9afc
Requested by: @iamnamananand996

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

[github-actions]

SDK Generation Benchmark Results

Comparing PR branch against median of 5 nightly run(s) on main (latest: 2026-06-05T05:30:09Z).

Full benchmark table (click to expand)

Generator	Spec	main (generator)	main (E2E)	PR (generator)	Delta
go-sdk	square	139s (n=5)	283s (n=5)	123s	-16s (-11.5%)

main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via fern generate). main (E2E): full customer-observable time including build/test scripts (nightly baseline, informational). Delta is computed against generator-only baseline.
⚠️ = generation exited with a non-zero exit code (timing may not reflect a successful run).
Baseline from nightly runs on main (latest: 2026-06-05T05:30:09Z). Trigger benchmark-baseline to refresh.
Last updated: 2026-06-05 20:54 UTC