fix(cli-generator): add --locked to cargo commands in emitted CI workflow#16310
Open
jsklan wants to merge 1 commit into
Open
fix(cli-generator): add --locked to cargo commands in emitted CI workflow#16310jsklan wants to merge 1 commit into
jsklan wants to merge 1 commit into
Conversation
…flow Co-Authored-By: judah <jsklan.development@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The generated
.github/workflows/ci.ymlemitted by the CLI generator used barecargo check/cargo build/cargo testin the check/compile/test jobs, allowing dependency re-resolution against the lockfile. The publish job already used--locked. This aligns all jobs to enforce the committed lockfile, matching whatseed.ymldoes.Changes Made
--lockedtocargo check,cargo build, andcargo testin bothconstructBuildTestYamlandconstructWorkflowYamlinemitPublishWorkflow.tsgithub-npmandgithub-no-publishfixturesTesting
generators/cli)--lockedflagLink to Devin session: https://app.devin.ai/sessions/acfe2c45830e44e0af353ae6bbf276f5
Requested by: @jsklan