-
Notifications
You must be signed in to change notification settings - Fork 323
feat(typescript): expose SSE event id and retry metadata #16677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dvdaruri-art
wants to merge
3
commits into
main
Choose a base branch
from
devin/1782307726-ts-sdk-sse-event-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
generators/typescript/sdk/changes/unreleased/expose-sse-event-metadata.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| - summary: | | ||
| Expose SSE event `id` and `retry` metadata in the TypeScript SDK's `Stream` class. | ||
| Users can now access `stream.lastEventId` during iteration, or use `stream.events()` | ||
| to iterate over `Stream.ServerSentEvent<T>` objects containing `data`, `event`, | ||
| `eventId`, and `retry` fields. This achieves parity with the Python SDK's | ||
| `ServerSentEvent` dataclass. | ||
| type: feat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 event: field is not tracked in the non-discriminated SSE path
In
iterDataMessages,event:lines are not explicitly recognized — they fall through to the data-prefix check at line 151-158 and get silently skipped (sinceevent: ...doesn't containdata:). The yieldedServerSentEvent<T>from this path never includes theeventfield. This is architecturally consistent with howiterDataMessagesworks (line-by-line without event-block semantics), but it meansevents()on a non-discriminated SSE stream provides less metadata than the discriminated path. Theevent:line association requires event-block boundaries (blank-line separation) to work correctly, so fixing this would require refactoringiterDataMessagesto understand event blocks, effectively merging it withiterSseEvents. This is related to but distinct from the reported retry bug.(Refers to lines 123-168)
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acknowledged — this is an inherent architectural limitation of
iterDataMessages. This path processesdata:lines independently (no blank-line event block accumulation), so there's no way to associate anevent:line with a specificdata:line without refactoring to full event-block parsing. Since non-discriminated SSE doesn't use theevent:field for dispatch (that's whatiterSseEventswitheventDiscriminatoris for), this is by design. Users who needevent:metadata should configureeventDiscriminatorin their API definition, which routes to the full-featurediterSseEventspath.