fix(typescript): guard against null/undefined in file upload core utility

generators/typescript/sdk/changes/unreleased/fix-file-upload-null-crash.yml

@@ -0,0 +1,6 @@
+- summary: |
+    Fix `TypeError: Cannot use 'in' operator to search for 'path' in undefined`
+    crash when `null` or `undefined` is passed to a file upload parameter at
+    runtime. The error is now a clear `TypeError` describing the expected types
+    instead of a cryptic `in` operator failure.
+  type: fix

generators/typescript/utils/core-utilities/src/core/file/file.ts

@@ -22,7 +22,11 @@ export async function toBinaryUploadRequest(
 
 export async function toMultipartDataPart(
     file: Uploadable,
-): Promise<{ data: Uploadable.FileLike; filename?: string; contentType?: string }> {
+): Promise<{ data: Uploadable.FileLike; filename?: string; contentType?: string } | undefined> {
+    if (file == null) {
+        console.warn(`File upload received ${file === null ? "null" : "undefined"}, skipping.`);
+        return undefined;
+    }
     const { data, filename, contentType } = await getFileWithMetadata(file, {
         noSniffFileSize: true,
     });
@@ -37,6 +41,11 @@ async function getFileWithMetadata(
     file: Uploadable,
     { noSniffFileSize }: { noSniffFileSize?: boolean } = {},
 ): Promise<Uploadable.WithMetadata> {
+    if (file == null) {
+        throw new TypeError(
+            `Expected file to be a Blob, Buffer, ReadableStream, or an object with a "path" or "data" property, but received ${file === null ? "null" : "undefined"}.`,
+        );
+    }
     if (isFileLike(file)) {
         return getFileWithMetadata(
             {

generators/typescript/utils/core-utilities/src/core/form-data-utils/FormDataWrapper.template.ts

@@ -79,7 +79,11 @@ export class Node18FormData implements CrossPlatformFormData {
     }
 
     public async appendFile(key: string, value: Uploadable): Promise<void> {
-        const { data, filename } = await toMultipartDataPart(value);
+        const part = await toMultipartDataPart(value);
+        if (part == null) {
+            return;
+        }
+        const { data, filename } = part;
 
         if (data instanceof Blob) {
             this.fd?.append(key, data, filename);
@@ -140,7 +144,11 @@ export class Node16FormData implements CrossPlatformFormData {
     }
 
     public async appendFile(key: string, value: Uploadable): Promise<void> {
-        const { data, filename } = await toMultipartDataPart(value);
+        const part = await toMultipartDataPart(value);
+        if (part == null) {
+            return;
+        }
+        const { data, filename } = part;
 
         let bufferedValue;
         if (data instanceof Blob) {
@@ -181,7 +189,11 @@ export class WebFormData implements CrossPlatformFormData {
     }
 
     public async appendFile(key: string, value: Uploadable): Promise<void> {
-        const { data, filename, contentType } = await toMultipartDataPart(value);
+        const part = await toMultipartDataPart(value);
+        if (part == null) {
+            return;
+        }
+        const { data, filename, contentType } = part;
 
         if (data instanceof Blob) {
             this.fd?.append(key, data, filename);
@@ -221,7 +233,11 @@ export class FormDataWrapper {
     }
 
     public async appendFile(key: string, value: Uploadable): Promise<void> {
-        const { data, filename, contentType } = await toMultipartDataPart(value);
+        const part = await toMultipartDataPart(value);
+        if (part == null) {
+            return;
+        }
+        const { data, filename, contentType } = part;
         const blob = await convertToBlob(data, contentType);
         if (filename) {
             this.fd.append(key, blob, filename);

generators/typescript/utils/core-utilities/tests/unit/file/file.test.ts

@@ -430,6 +430,22 @@ describe("toBinaryUploadRequest", () => {
         });
     });
 
+    describe("null and undefined input", () => {
+        it("should throw TypeError for undefined in binary upload", async () => {
+            await expect(toBinaryUploadRequest(undefined as unknown as Uploadable)).rejects.toThrow(TypeError);
+            await expect(toBinaryUploadRequest(undefined as unknown as Uploadable)).rejects.toThrow(
+                /but received undefined/,
+            );
+        });
+
+        it("should throw TypeError for null in binary upload", async () => {
+            await expect(toBinaryUploadRequest(null as unknown as Uploadable)).rejects.toThrow(TypeError);
+            await expect(toBinaryUploadRequest(null as unknown as Uploadable)).rejects.toThrow(
+                /but received null/,
+            );
+        });
+    });
+
     describe("Edge cases", () => {
         it("should handle empty headers when no metadata is available", async () => {
             const buffer = Buffer.from("");