fix(openapi): avoid OAuth scope type collisions - #17412
Draft
ngyna wants to merge 3 commits into
Draft
Conversation
There was a problem hiding this comment.
AI Review Summary
Adds collision-avoidance for the synthetic OauthScope enum in the OpenAPI importer, plus a fixture and snapshots. The core logic is straightforward, but the collision scan is both too coarse (ignores groupName, so it renames even when the colliding schema lands in a different file) and too narrow (ignores namespaced schemas), and getSchemaName can return undefined for schema variants without a generated name, which would blow up on .toLowerCase().
- 🟡 2 warning(s)
- 🔵 2 suggestion(s)
ngyna
force-pushed
the
anguyen-fern-oauth-scope-collision
branch
2 times, most recently
from
August 14, 2026 04:38
f657318 to
309a8a4
Compare
ngyna
force-pushed
the
anguyen-fern-oauth-scope-collision
branch
from
August 14, 2026 04:44
309a8a4 to
a910009
Compare
ngyna
marked this pull request as draft
August 14, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17411. The OpenAPI importer now preserves a user-defined
OAuthScopeinstead of letting Fern's syntheticOauthScopeenum converge on the same generated file path.OauthScopefor unaffected APIs and choose a deterministicOauthAuthorizationScopefallback only on a genuine case-insensitive collision.