fix(openapi): preserve nullable component references - #17417
Draft
ngyna wants to merge 1 commit into
Draft
Conversation
![nitpickybot[bot]](https://avatars.githubusercontent.com/in/2901896?s=60&v=4){kind=small}
There was a problem hiding this comment.
AI Review Summary
The fix replaces in-place mutation of the shared resolved schema with a local shallow copy plus non-mutating type-array filtering — the right general approach, and the regression test is order-sensitive as it should be. Two things to double-check: the copy is only shallow, and one degenerate type-array case changes behavior.
- 🟡 1 warning(s)
- 🔵 1 suggestion(s)
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ngyna
force-pushed
the
anguyen-fern-nullable-allof
branch
from
August 14, 2026 06:38
78be336 to
975d6a4
Compare
ngyna
marked this pull request as draft
August 14, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17416. The legacy OpenAPI parser now preserves OpenAPI 3.1 type-array nullability when the same resolved component is converted through a documented allOf reference and then referenced again.