fix(openapi): infer binary responses from media types - #17419
Draft
ngyna wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
AI Review Summary
Adds media-type-driven binary inference in both the legacy and v3 importers, plus a heuristic for typeless contentMediaType schemas. Logic is duplicated verbatim across two packages, the new early-return in ResponseBodyConverter bypasses the existing media-type parsing path (including any streaming handling), and the !isXML() carve-out makes the two importers disagree on image/svg+xml (visible in the two new snapshots: baseline → fileDownload, v3 → empty object).
- 🔴 1 critical issue(s)
- 🟡 2 warning(s)
- 🔵 2 suggestion(s)
ngyna
force-pushed
the
anguyen-fern-raw-binary-responses
branch
from
August 14, 2026 15:35
e1af8d2 to
b0325b1
Compare
ngyna
force-pushed
the
anguyen-fern-raw-binary-responses
branch
from
August 14, 2026 15:37
b0325b1 to
74dbbc1
Compare
ngyna
marked this pull request as draft
August 14, 2026 16:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17415.
OpenAPI 3.1 raw ZIP/PDF responses and unencoded binary component schemas now retain Fern's existing file/string-binary representation without requiring legacy
type: string/format: binaryhints.