Fix _parseTags() causing error when songs are missing tags#17
Open
benpm wants to merge 3 commits intofeross:masterfrom
Open
Fix _parseTags() causing error when songs are missing tags#17benpm wants to merge 3 commits intofeross:masterfrom
benpm wants to merge 3 commits intofeross:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really simply fix, just making
_parseTags()return an empty list when track.toptags or track.toptags.tag are missingEdit: okay the issue i was experiencing was actually because tags.tag can sometimes be an object instead of an array of objects:
So now I've fixed _parseTags so that it can handle that