Merged
Conversation
The HTML process now correctly shuts down when it receives a `feGoodbye` packet.
The network process now responds to `feGoodbye` packets. The cleanup sequence is as follows: - Shut down all open WebSocket connections - Shut down the main cURL handle, halt all in-flight connections and deallocate all memory occupied by it.
The JavaScript process now reacts to `feGoodbye` packets. The cleanup sequence needs some work. (It currently segfaults as soon as it's about to exit, most likely due to some problem in Bali!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ferus currently just leaves behind a messy trail of processes that have nothing to do and just sit around after the renderer exits due to user interaction.
This PR fixes it by making the master propagate "goodbye" packets to ALL processes it knows. Those processes start cleaning up and stop their event loop as
soon as they get the packet.
The JavaScript runtime's cleanup sequence needs a bit of work because it currently just segfaults when it has to exit. Possibly something in Bali being silly?