当传入的 user-agent 不是字符串的时候，内部没有处理，导致抛出脚本错误#21
Open
norfish wants to merge 0 commit intofex-team:masterfrom
Open
Conversation
norfish
changed the title
Contributor
|
嗯，你说的很对，确实没有注意数据类型判断的问题，平时我在用它的时候是在外层包的try catch，所以就没在内部进行对应的处理 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ua的参数不是正常的 user-agent 字符串的时候，new UA 会直接抛出脚本错误，这次修改对非字符串的参数做了兼容，当传入非法参数的时候静默返回，确保decect结果可以正常使用
另外这一行我不确定要不要加上
// throw new TypeError('ua must be a string')是否需要抛出一个自定义的Type Error出来，我倾向于不抛出来。因为ua-device是个第三方库，应该对用户传入的参数做各种兼容处理，而不是直接抛出错误，导致用户进程 crash 掉