This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Move AUTH_TOKEN to .dev.vars and update README with instructions for setting AUTH_TOKEN secret
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions for AUTH_TOKEN usage
brettimus
force-pushed
the
update-readme
branch
from
a6fb91b to
3dff18b
Compare
brettimus
changed the title
AUTH_TOKEN to `.dev.vars and update README with instructions for setting AUTH_TOKEN secretAUTH_TOKEN to .dev.vars and update README with instructions for setting AUTH_TOKEN secret
laulauland
approved these changes
Feb 17, 2025
| @@ -0,0 +1 @@ | |||
| AUTH_TOKEN="your-secret-token-here" No newline at end of file | |||
There was a problem hiding this comment.
nit but maybe we could make this OTEL_WORKER_AUTH_TOKEN to make it more explicit
There was a problem hiding this comment.
ah wait, realizing this will require a more substantial change throughout the code, so feel free to disregard
There was a problem hiding this comment.
Think this is also making it quite verbose, specially since these envvars are scoped to a single app
hatchan
suggested changes
Feb 17, 2025
changed! |
hatchan
approved these changes
Feb 17, 2025
|
deployed and tested with https://brett-otel-worker.fp.dev, going to merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a few small tweaks to how the
AUTH_TOKENis set, and updated the README accordingly.Since
wrangler.tomlis checked into version control, it's recommended to put secrets in.dev.varsfor developing locally, and then set the secret for the worker vianpx wrangler secret put NAME_OF_SECRET.This also prevents the
[vars]inwrangler.tomlfrom clobbering any runtime variables you set manually when you go to deploy.