[Fil 1087] reproduce phantom commit and fix it#133
Merged
JAG-UK merged 2 commits intofidlabs:masterfrom Nov 30, 2025
Merged
Conversation
RafalMagrys
commented
Nov 27, 2025
|
|
||
| const mocks = vi.hoisted(() => ({ | ||
| logger: { | ||
| info: vi.fn((...args) => console.log(...args)), |
Collaborator
Author
There was a problem hiding this comment.
Added to see logs in tests and having them mocked at the same time
RafalMagrys
commented
Nov 27, 2025
...pplication/src/application/use-cases/edit-application/subscribe-application-edits.service.ts
Show resolved
Hide resolved
RafalMagrys
commented
Nov 27, 2025
| public source: EventSource; | ||
|
|
||
| constructor(aggregateId: string) { | ||
| constructor(aggregateId: string, source: EventSource = 'api') { |
Collaborator
Author
There was a problem hiding this comment.
I made every event source an API by default. Only some of the edits will have a GitHub source, so they won't be published back to GitHub
RafalMagrys
commented
Nov 27, 2025
| expect(mocks.airtableClient.getTableRecords).toHaveBeenCalledTimes(1); | ||
| expect(mocks.commandBus.send).toHaveBeenCalledTimes(1); | ||
| expect(mocks.commandBus.send).toHaveBeenCalledWith(expect.any(CreateApplicationCommand)); | ||
| expect(mocks.logger.error).toHaveBeenCalledWith( |
Collaborator
Author
There was a problem hiding this comment.
I know these aren't the best test checks, but without refactoring the subscribers, I can't rely on anything other than the logs
RafalMagrys
commented
Nov 27, 2025
| data: { guid: '123' }, | ||
| }); | ||
|
|
||
| vi.useFakeTimers(); |
Collaborator
Author
There was a problem hiding this comment.
It's necessary to test the timers correctly so that I can manipulate the awaits from setInterval and prevent them from overlapping
JAG-UK
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.