Skip to content

Take Refresh address from address, not msig#143

Merged
JAG-UK merged 3 commits intofidlabs:masterfrom
JAG-UK:master
Feb 23, 2026
Merged

Take Refresh address from address, not msig#143
JAG-UK merged 3 commits intofidlabs:masterfrom
JAG-UK:master

Conversation

@JAG-UK
Copy link
Copy Markdown
Contributor

@JAG-UK JAG-UK commented Feb 23, 2026

Required for compatibility with MetaAllocators.

): IssueDetails {
return {
...issue,
msigAddress: allocator?.pathway_addresses?.msig,
Copy link
Copy Markdown
Collaborator

@RafalMagrys RafalMagrys Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its okay, but can we leave allocator?.pathway_addresses?.msig as backup when allocator?.address is missing ?
msigAddress: allocator?.address || allocator?.pathway_addresses?.msig

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address should never be missing. If it is then the application was wrong and the gov team shouldn't allow it through.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright

@RafalMagrys RafalMagrys self-requested a review February 23, 2026 18:59
@JAG-UK JAG-UK merged commit 7d75643 into fidlabs:master Feb 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants