[Fil 1399] [Client sc] remove longest deal term#30
Merged
RafalMagrys merged 7 commits intomainfrom Mar 24, 2026
Merged
Conversation
Filip-L
requested changes
Mar 20, 2026
Filip-L
approved these changes
Mar 22, 2026
CodeWarriorr
requested changes
Mar 23, 2026
Collaborator
CodeWarriorr
left a comment
CodeWarriorr
left a comment
There was a problem hiding this comment.
this pr will conflict heavily and should be rebased on top of #21
blocked for now
RafalMagrys
force-pushed
the
FIL-1399-client-sc-remove-longest-deal-term
branch
from
14fd7bc to
db24928
Compare
CodeWarriorr
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientSCis done here [FIL-1353] Client Contract adjustments and clenup #21, This one focuses only on the removal of the longest deal term and related things.ReentrantValidatorMockis obsolete since we won't use updateLockupPeriod inside the transfer function.ReentrantMetaAllocatorMockto enable reentrancy testing againIValidatorinterface has been removed as it is also obsolete.