Fix the version in package.json file while GHA call image build#10
Merged
lukasz-wal merged 1 commit intomainfrom Mar 18, 2025
Merged
Fix the version in package.json file while GHA call image build#10lukasz-wal merged 1 commit intomainfrom
lukasz-wal merged 1 commit intomainfrom
Conversation
lukasz-wal
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The docker image doesn't contain the updated version in package.json while the image build was called by GHA.
Solution:
Pass the sha commit after the update version into staging/production jobs to pull on the right one