Add S2 scene caching for faster downloads#61
Draft
avis-giri wants to merge 3 commits into
Draft
Conversation
- Created cache_service.py with caching logic
- Modified pipeline.py to check cache before S3 download
- Year-based cache organization (data/cache/scenes/{year}/)
- Cache only dual-window scenarios
Addresses #17
asmithml
requested changes
Nov 6, 2025
Comment on lines
+31
to
+45
| # Check cache first (only for dual window scenarios) | ||
| if win_b is not None: | ||
| cached, cached_path = await check_s2_scene_exists(win_a, win_b, bbox) | ||
|
|
||
| if cached and cached_path is not None: | ||
| logger.info("Using cached S2 scene", extra=context) | ||
| shutil.copy2(cached_path, image_file) | ||
| download_time = round((time.time() - download_start) * 1000, 2) | ||
| image_size_mb = round(image_file.stat().st_size / (1024 * 1024), 2) | ||
|
|
||
| return { | ||
| "download_time_ms": download_time, | ||
| "image_size_mb": image_size_mb, | ||
| "from_cache": True, | ||
| } |
Member
There was a problem hiding this comment.
It doesn't look like there is a way to cache single windows. We want to cache the individual files, and then call them if they are needed. It should work for models that only need a single window, as well as models with two windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #17