Enable properties box for PMTiles of global data#245
Conversation
ahocevar
left a comment
There was a problem hiding this comment.
For vector tiles, just highlighting the clicked feature produces ugly results for polygons that cross tile boundaries, because they will be cut off with a buffer. The correct technique is to add a selection layer, which is a VectorTile layer with the same source as the original layer, and with a style that only highlights features with the selected features' feature id. This will of course only work when the PMTiles features have a feature id. Alternatively, any id that is shared across the parts of a chopped feature will do.
@m-mohr Let me know if you want me to give this a pass, or if you want to do look at this yourself. Can also be a follow-up pull request if it makes things easier.
|
Thanks, that's a good point. The features in the PMTiles file don't have an ID and nothing else that can reliably be used as an alternative (I think), so we are out of luck here, right? |
Unfortunately yes. |
|
Okay, I'll discuss with the team whether we want this functionality or not. Might be that it doesn't add a lot, so maybe we just don't merge this at all. |
|
@m-mohr Let me know if this feature is desired, then I'll add hit detection handling to the worker based prediction layer. |
|
Thanks. I think, we won't add this in the next version, maybe in a late version. |
I'm not sure whether we want this, but we could also enable the same properties box as in inference mode.
We may want to filter / fine-tune the properties shown.
Was considering showing year and confidence metrics, hide other properties.
We could potentially try to compute area and perimeter on the fly, because they are lacking here but are part of the inference result properties.