Skip to content

Enable properties box for PMTiles of global data#245

Draft
m-mohr wants to merge 1 commit into
mainfrom
global/properties-box
Draft

Enable properties box for PMTiles of global data#245
m-mohr wants to merge 1 commit into
mainfrom
global/properties-box

Conversation

@m-mohr
Copy link
Copy Markdown
Collaborator

@m-mohr m-mohr commented Apr 13, 2026

I'm not sure whether we want this, but we could also enable the same properties box as in inference mode.

We may want to filter / fine-tune the properties shown.

Was considering showing year and confidence metrics, hide other properties.

We could potentially try to compute area and perimeter on the fly, because they are lacking here but are part of the inference result properties.

@m-mohr m-mohr added this to the 1.1 - Global Data milestone Apr 13, 2026
@m-mohr m-mohr requested a review from ahocevar April 13, 2026 12:03
Copy link
Copy Markdown
Collaborator

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For vector tiles, just highlighting the clicked feature produces ugly results for polygons that cross tile boundaries, because they will be cut off with a buffer. The correct technique is to add a selection layer, which is a VectorTile layer with the same source as the original layer, and with a style that only highlights features with the selected features' feature id. This will of course only work when the PMTiles features have a feature id. Alternatively, any id that is shared across the parts of a chopped feature will do.

@m-mohr Let me know if you want me to give this a pass, or if you want to do look at this yourself. Can also be a follow-up pull request if it makes things easier.

@m-mohr
Copy link
Copy Markdown
Collaborator Author

m-mohr commented Apr 13, 2026

Thanks, that's a good point. The features in the PMTiles file don't have an ID and nothing else that can reliably be used as an alternative (I think), so we are out of luck here, right?

@ahocevar
Copy link
Copy Markdown
Collaborator

The features in the PMTiles file don't have an ID and nothing else that can reliably be used as an alternative (I think), so we are out of luck here, right?

Unfortunately yes.

@m-mohr
Copy link
Copy Markdown
Collaborator Author

m-mohr commented Apr 14, 2026

Okay, I'll discuss with the team whether we want this functionality or not. Might be that it doesn't add a lot, so maybe we just don't merge this at all.

@ahocevar
Copy link
Copy Markdown
Collaborator

@m-mohr Let me know if this feature is desired, then I'll add hit detection handling to the worker based prediction layer.

@m-mohr
Copy link
Copy Markdown
Collaborator Author

m-mohr commented Apr 21, 2026

Thanks. I think, we won't add this in the next version, maybe in a late version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants