Skip to content

Added checkbox to show/hide boundaries when zoomed in past render threshold#255

Merged
m-mohr merged 5 commits into
mainfrom
add_checkbox
Apr 21, 2026
Merged

Added checkbox to show/hide boundaries when zoomed in past render threshold#255
m-mohr merged 5 commits into
mainfrom
add_checkbox

Conversation

@calebrob6
Copy link
Copy Markdown
Contributor

Adds a checkbox that allows me to toggle the fields on off -- helpful when I want to see the underlying imagery. Checkbox is disabled until you zoom past GLOBAL_DATA_MAP_FIELD_START_ZOOM_LEVEL

image

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a user-facing toggle to show/hide global field boundary overlays, intended to make it easier to inspect underlying imagery while using the global predictions map mode.

Changes:

  • Extend persisted Settings with showFieldBoundaries (default true).
  • Apply the visibility setting to the global predictions layer and react to changes.
  • Add a “Show field boundaries” checkbox in GlobalDataPanel, disabled until GLOBAL_DATA_MAP_FIELD_START_ZOOM_LEVEL.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/composables/useSettings.ts Adds showFieldBoundaries to settings + default value for persistence.
src/composables/useMap.ts Sets global predictions layer visibility from settings and watches for toggles.
src/components/GlobalDataPanel.vue Adds zoom-gated checkbox UI bound to settings.showFieldBoundaries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/GlobalDataPanel.vue
Copy link
Copy Markdown
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling the field boundaries is not reflected in the URL, making the link not easily sharable.


I'm not sure whether it's better or worse, but I'm just thinking we could also do something like this:

Image

@calebrob6
Copy link
Copy Markdown
Contributor Author

Disabling the field boundaries is not reflected in the URL, making the link not easily sharable.

Fixed. I don't really have an opinion on whether this is in the existing radio button or not

@m-mohr
Copy link
Copy Markdown
Collaborator

m-mohr commented Apr 21, 2026

Thanks. I just had another Idea. Why not add an opacity slider? Then you could set opacity to whatever makes let's you best judge the boundaries. 0 would be equivalent to now shown. We could or could not apply the opacity also to the overview layer.

More todos:

Approving as the blockers are solved, but I think it's worth discussing the other options. Could be part of a different PR.

@m-mohr
Copy link
Copy Markdown
Collaborator

m-mohr commented Apr 21, 2026

Merging for now, will create a separate PR for the opacity.

@m-mohr m-mohr merged commit 820937a into main Apr 21, 2026
1 check passed
@m-mohr m-mohr deleted the add_checkbox branch April 21, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants