feat: Attested Signatures + UCAN Principal Clarification#1
Merged
Conversation
Adapt to the ucantone PR #30 principal/signing refactor. A ucan.Signer is no longer a Principal and has no DID; the "signer bound to a Principal" role is now ucan.Issuer. The principal/* key packages moved to multikey/*. generateSigner now returns a ucan.Issuer built via each multikey package's GenerateIssuer helper (ed25519.GenerateIssuer / secp256k1.GenerateIssuer), so callers can still .DID() it and pass it to .Delegate/.Invoke. The mldsa44 branch is dropped because that key type is no longer provided by ucantone. Bumps ucantone and libforge to the refactored versions. See fil-forge/ucantone#30 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014dZyvL474aA43c1C7E6ZpV
The earlier attested-signatures migration had to drop the mldsa44 (post-quantum ML-DSA-44) key branch because that key type did not exist on ucantone main after the principal/* -> multikey/* refactor. It has now been reinstated on the new layout in fil-forge/ucantone#37, so this restores the mldsa44 case using multikey/mldsa44.GenerateIssuer() and re-pins ucantone at that commit. Because ucantone#37 is not yet merged, this points at that unmerged commit (the new multikey/mldsa44 branch) rather than the old unmerged principal/mldsa44 commit it referenced before. Re-pin to a merged ucantone once #37 lands. See fil-forge/ucantone#30 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014dZyvL474aA43c1C7E6ZpV
alanshaw
approved these changes
Jul 2, 2026
Peeja
marked this pull request as ready for review
July 2, 2026 19:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the coordinated "Attested Signatures + UCAN Principal Clarification" rollout, which merged in
ucantoneand the sibling repos but never got a PR here.Dependency bumps
github.com/fil-forge/ucantone→v0.0.0-20260702175651-12732483947fgithub.com/fil-forge/libforge→v0.0.0-20260701162346-f0706e1641a3Code adaptation (
main.go)Under PR #30 a
ucan.Signeris no longer aPrincipal(no.DID()); the "signer bound to a Principal" role is nowucan.Issuer, and the key packages moved fromucantone/principal/*toucantone/multikey/*.generateSignernow returns aucan.Issuerbuilt via each multikey package'sGenerateIssuer()helper (the pattern used across the migrated siblings — e.g. guppy'scmd/space/generate.go):All call sites are unchanged —
.DID()and passing the value as theucan.Issuerfirst arg tocontentcmds.Retrieve.Delegate(...)/.Invoke(...).mldsa44 (post-quantum ML-DSA-44) is retained
ML-DSA-44 was never on
ucantonemain— it lived only in the unmerged PR #32 (oldprincipal/mldsa44layout), which is the exactucantonecommit this repo had originally pinned. Rather than drop it, it has been re-ported onto the newmultikeylayout in fil-forge/ucantone#37, and this PR keeps themldsa44branch using the newmultikey/mldsa44package.Verified:
GOWORK=off go build ./... && go vet ./...clean;go run .emits theX-UCAN-Containerblocks without panicking for both the default ed25519 path (769 B container) and themldsa44path (~11 kB container, consistent with ML-DSA's large signatures).Opened as a draft for review.
🤖 Generated with Claude Code
https://claude.ai/code/session_014dZyvL474aA43c1C7E6ZpV