Skip to content

itest: boot piri on Postgres so the stack comes up; accept any 2xx CORS preflight #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bajtos wants to merge 2 commits into from
Closed

itest: boot piri on Postgres so the stack comes up; accept any 2xx CORS preflight #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
900d6b5
itest: fix CORS preflight status expectation (200, not 204)
claude Jul 28, 2026
574a0a5
itest: boot piri on Postgres so the stack comes up
claude Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions itest/scenarios_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,14 @@ func TestForgeScenarios(t *testing.T) {
return resp
}

// Any 2xx is a successful preflight per the fetch spec; versitygw
// answers a matched rule 200 and only its no-CORS-config fallback
// 204. The Max-Age assertion below is what pins the real path — the
// fallback sets no Max-Age and mirrors the requested method instead
// of the rule's method list.
resp := preflight(t, origin)
if resp.StatusCode != http.StatusNoContent {
t.Errorf("preflight status = %d, want 204", resp.StatusCode)
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
t.Errorf("preflight status = %d, want 2xx", resp.StatusCode)
}
if got := resp.Header.Get("Access-Control-Allow-Origin"); got != origin {
t.Errorf("preflight Allow-Origin = %q, want the request origin echoed", got)
Expand Down
4 changes: 3 additions & 1 deletion itest/stack_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ func forgeStack(t *testing.T, extra ...stack.Option) (*stack.Stack, string) {
t.Helper()
t.Logf("booting the smelt Forge stack (~1-2 min; first run also compiles ingot and pulls images)")
opts := []stack.Option{
stack.WithPiriNodes(stack.PiriNodeConfig{}),
// Postgres-backed piri: piri:main's curio PDP pipeline refuses
// sqlite ("curio PDP pipeline requires Postgres") as of 2026-07-24.
stack.WithPiriNodes(stack.PiriNodeConfig{Postgres: true}),

@bajtos bajtos Jul 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to change stack.WithPiriNodes to configure Postgres by default. Perhaps as part of the larger cleanup to remove SQLite from Piri & Smelt.

@bajtos bajtos Jul 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that's the right end state — but WithPiriNodes / PiriNodeConfig live in fil-forge/smelt, so flipping the default can't land in this PR. Keeping this one line here is the minimum to get a red suite green against the smelt version ingot currently pins.

Worth noting for whenever the smelt cleanup happens: this line can't rot silently either way. If smelt just flips the default, Postgres: true becomes redundant but stays correct. If the field goes away entirely along with sqlite, this becomes a compile error at bump time — so it surfaces immediately rather than quietly reverting the suite to sqlite.

Happy to pick up the smelt-side change (invert or drop the field, then drop this argument here) as a follow-up if you want to point me at it — it's outside this repo, so it needs its own PR there.

Generated by Claude Code

stack.WithServiceBinary("ingot", localIngotBinary(t)),
}
// Local-dev escape hatches: run against upload-service (sprue) / piri
Expand Down
Loading