docs: propose the S3 object-tagging design (VersionState second tenant) - #80
Merged
Merged
Conversation
hannahhoward
approved these changes
Aug 13, 2026
hannahhoward
left a comment
Contributor
There was a problem hiding this comment.
My eyes are glazing a bit, but this looks simple enough. LGTM
Object tagging rides the version-state tree the object-lock design built: the Tags field is already reserved on VersionState, so tagging is handlers and conformance rows with no format change. The spec pins the three deltas from lock: no bucket gate (the check order drops the lock-enabled step, and tags on unversioned buckets make the write-rule discard cleanup live), absent state is a success (empty tag set, not a sentinel), and DeleteObjectTagging is the true unset the empty-block elision rule exists for. Creation-time stamping covers the x-amz-tagging header on PUT (parsed backend-side via backend.ParseObjectTags), the copy tagging directive (controller-defaulted to COPY), and the multipart session carry; GET/HEAD gain the tag-count echo. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
frrist
force-pushed
the
design/s3-object-tagging
branch
from
August 14, 2026 00:56
4e3b30f to
b6c9581
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design doc for S3 object tagging, following the doc-then-impl stack workflow — stacked on #78 (the object-lock implementation), because tagging is the second tenant of the version-state tree that design built. Rebases down the stack as #77/#78 land.
Tagging rides the lock design's format exactly as planned: the
Tagsfield is already reserved onVersionState, so this is handlers and conformance rows with no format change. The spec pins the three deltas from lock:DeleteObjectTaggingis what the state tree's empty-block elision rule was written for.Creation-time stamping covers the
x-amz-taggingheader on PUT (parsed backend-side viabackend.ParseObjectTags, before ingest), the copy tagging directive (controller-defaulted to COPY: inherit the resolved source version's tags; REPLACE takes the header), and the multipart session carry. GET/HEAD gain thex-amz-tagging-countecho from the same state-block fetch as the lock headers.Implementation follows as the stacked PR from
frrist/feat/object-tagging.🤖 Generated with Claude Code