fix: bigint support#27
Merged
Merged
Conversation
frrist
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes support for big ints. Instead of leaning on a custom big int type (
go-state-types/big), we use nativemath/big.It also adds support for big ints when marshaling to/from JSON.
JSON encoded numbers do not have a fixed size, so it's impossible to distingish between
int64andbig.Intwhen decoding, without inventing a custom representation of these different types. The decision here is to decode a number toint64when the value fits, but otherwise use abig.Int. The trade off is that when encoding "small" big ints, you'll get back anint64when you decode i.e. they won't round trip.If you need the round trip to work you should use
dag-json-gento generate encoders/decoders. Alternatively use your own custom type, orstringor[]bytesto represent the value.Related alanshaw/dag-json-gen#1 for negative bigint support.