-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Refactor: Use outline instead of ring #15752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.x
Are you sure you want to change the base?
Refactor: Use outline instead of ring #15752
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
302a650
to
86f1604
Compare
override browser default outline
Part of the migration from ring to outline should be using a consistent outline color. This improves current cases of the danger color being used for inputs with validation errors, which in hindsight is suboptimal. |
Which one do we want to use? primary or browsers default? I think primary should work better because browsers could potentially have different default colors. Let me know if I misunderstood something! |
Description
Closes #13733
Visual changes
none
Functional changes
composer cs
command.