Skip to content

Refactor: Use outline instead of ring #15752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: 4.x
Choose a base branch
from

Conversation

thethunderturner
Copy link
Contributor

Description

Closes #13733

Visual changes

none

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@github-project-automation github-project-automation bot moved this to Todo in Roadmap Mar 1, 2025
@thethunderturner thethunderturner marked this pull request as draft March 1, 2025 14:56
@thethunderturner

This comment was marked as resolved.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Roadmap Mar 3, 2025
@thethunderturner thethunderturner marked this pull request as ready for review March 13, 2025 15:25
@zepfietje
Copy link
Member

Part of the migration from ring to outline should be using a consistent outline color.
Currently the primary color is used, which is an option, or we default to the browser's accent color as per the default behavior.

This improves current cases of the danger color being used for inputs with validation errors, which in hindsight is suboptimal.

@thethunderturner
Copy link
Contributor Author

Part of the migration from ring to outline should be using a consistent outline color. Currently the primary color is used, which is an option, or we default to the browser's accent color as per the default behavior.

This improves current cases of the danger color being used for inputs with validation errors, which in hindsight is suboptimal.

Which one do we want to use? primary or browsers default? I think primary should work better because browsers could potentially have different default colors. Let me know if I misunderstood something!

@zepfietje zepfietje linked an issue Apr 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Use outline instead of ring
4 participants