[4.x] Create RichContentFaker class #18100
Open
+212
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awcodes
changed the title
awcodes
requested review from
Copilot and
danharrin
and removed request for
Copilot
awcodes
changed the title
danharrin
requested changes
Oct 7, 2025
|
Do you want it tested against the renderer output or the content in the editor in the browser? |
|
Not sure what you mean? Tested against the output of the PHP function, no need for a browser test |
|
Maybe I'm just not clear on what you mean by "snapshot" test. I'm my mind snapshot implies browser. But as long as the RichContentRender outputs the correct html or json/array I think that satisfies the test. Am I wrong? |
|
It's not a screenshot, it stores text: https://pestphp.com/docs/snapshot-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
RichContentFakerclass to allow for easier population of rich editor content in factories and tests.Functional changes
composer cscommand.