[4.x] Mounted action modal test helpers #18195
Conversation
|
@danharrin PhpStan does not understand that those are macros and I used a helper method so I don't have to repeat getting the partial HTML. I can extract it into a helper method and place it over the class or inline and repeat the code. WDYT? |
|
I think the methods need adding to the testing stubs file like the others. After that, we can add ignores where we are calling macroed functions. |
There was a problem hiding this comment.
If there is a request while the the modal is open, for example, if a live field is changed, I think the partial name becomes action-modal.NESTING-INDEX or something similar. Probably needs checking. action-modals is only used on a request where a modal is opened or closed
| * | ||
| * @internal | ||
| */ | ||
| public function getMountedActionModalHtml(): string {} |
There was a problem hiding this comment.
Do we need to include this in the stubs if we ignore all its usages anyway?
There was a problem hiding this comment.
Honestly, I have no idea how this stub file is used. I thought it's a file for PhpStan (https://phpstan.org/user-guide/stub-files) but I don't find it in the PhpStan config.
|
You are right. I adjusted the code to use either the general key or one with a nesting index. Is there a scenario where multiple nested actions are rendered at once? |
2 participants
Description
More assertion methods for testing modal content: #17857
Functional changes
composer cscommand.