feat(tables): inject relationship record into column item closures - #20081
Open
mohammedelkarsh wants to merge 2 commits into
Open
feat(tables): inject relationship record into column item closures#20081mohammedelkarsh wants to merge 2 commits into
mohammedelkarsh wants to merge 2 commits into
Conversation
Allow table column closures to receive the related Eloquent model for each relationship state item via $relationshipRecord, enabling per-item styling and formatting for relationship columns. Fixes filamentphp#19121
danharrin
requested changes
Jul 8, 2026
danharrin
left a comment
Member
There was a problem hiding this comment.
Please fix the merge conflicts
Resolve conflicts in TextColumn and IconColumn by keeping upstream a11y and formattedState improvements while preserving relationshipRecord injection for per-item column closures.
Author
|
@danharrin Thanks for the review — merge conflicts are resolved. Rebased/merged latest
Happy to address any further feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
color(), `tooltip()`, `url()`, `formatStateUsing()`, `icon()`, etc.) for relationship columns such as `teams.name`getRelationshipRecords()andgetRelationshipRecord()Fixes #19121
Test plan
php vendor/bin/pest tests/src/Tables/Columns/RelationshipRecordColumnTest.php(16 tests)