feat(query-builder): enable complexity limits by default - #20259
Open
hamdyelbatal122 wants to merge 1 commit into
Open
feat(query-builder): enable complexity limits by default#20259hamdyelbatal122 wants to merge 1 commit into
hamdyelbatal122 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20223
Description
This PR addresses issue #20223 by enabling query builder complexity limits by default in
6.x.Currently,
maxRules()andmaxNestingDepth()default tonull(unlimited), which can lead to high resource consumption if excessively large or deeply nested condition trees are submitted.This sets the default limits to:
maxRules:100conditionsmaxNestingDepth:5levels for "OR" groupsDocumentation, test cases, and rule builder properties have been updated to align with these new defaults.
Visual changes
Functional changes
composer cscommand.