Fix CTRL/CMD+S on Filament v3 create/edit pages - #20333
Open
tominal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Filament v3.3.53 received a frontend rebuild which contained a change in mousetrap.
Full description here: danharrin/alpine-mousetrap#14
TL;DR: All closed modals trip the mousetrap getOpenModal() check, so CTRL/CMD+S is failing since 3.3.53.
Visual changes
N/A
Functional changes
CTRL/CMD+S opens the native browser save dialog instead of triggering mousetrap to execute the save operation on create/edit pages.
This fix matches how v4 and v5 modals are built in HTML which matches what mousetrap is currently built to check.
composer cscommand.Remove the aria attributes from the top-level div:
And move them into the child div that controls the visibility of the modal: