FIP-0118: editorial cleanup and missing sections - #1271
Merged
Conversation
rvagg
requested review from
TippyFlitsUK,
anorth,
dannyob,
jennijuju,
jsoares,
lanzafame and
momack2
as code owners
July 30, 2026 03:23
TippyFlitsUK
approved these changes
Jul 30, 2026
Member
Author
|
latest tweak just adds code formatting to elements that deserve it, and a little bit more line wrapping treatment for consistency, no material changes |
dannyob
approved these changes
Aug 4, 2026
dannyob
left a comment
Contributor
There was a problem hiding this comment.
Some minor language suggestions/typos. LGTM!
jsoares
approved these changes
Aug 4, 2026
jsoares
left a comment
Member
There was a problem hiding this comment.
Many TODOs, obviously -- and a pending stacked PR -- but this is in great shape for the stage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unfortunately pulls in all of #1270 because that comes from a fork and I want to add a commit on top of it that needs its own review. So when reviewing, please look at the head commit (only), the rest is the same as on #1270.
The intention here is to make this mergable in its current form. This change applies all of the non-controversial editorial and technical clean-ups that I highlighted in my review of #1270 and fills in a couple of the blank sections so it's ~complete. There's more updates to come based on the technical work, next for me would be changes coming out of the f02 design work which are not trivial changes but I'll keep them separate.
In this PR:
#1270 didn't have any editor reviews, this is going to need 2 explicit ones on top of my implicit one to land. When we have that, I'll squash down @irenegia's commits to one and then we'll have a base to iterate on in this repo.