Skip to content

FIP-0118: editorial cleanup and missing sections - #1271

Merged
TippyFlitsUK merged 3 commits into
masterfrom
rvagg/0118
Aug 5, 2026
Merged

FIP-0118: editorial cleanup and missing sections#1271
TippyFlitsUK merged 3 commits into
masterfrom
rvagg/0118

Conversation

@rvagg

@rvagg rvagg commented Jul 30, 2026

Copy link
Copy Markdown
Member

This unfortunately pulls in all of #1270 because that comes from a fork and I want to add a commit on top of it that needs its own review. So when reviewing, please look at the head commit (only), the rest is the same as on #1270.

The intention here is to make this mergable in its current form. This change applies all of the non-controversial editorial and technical clean-ups that I highlighted in my review of #1270 and fills in a couple of the blank sections so it's ~complete. There's more updates to come based on the technical work, next for me would be changes coming out of the f02 design work which are not trivial changes but I'll keep them separate.

In this PR:

  • Clarify reward-stream, weight, share and burn terminology ("weight" and "share" are both fractions but entirely separate, so the FIP should be clean on this)
  • Correct stale statements, arithmetic, timing and section references.
  • Tighten datacap deprecation and QAP transition wording.
  • Narrow misleading consensus, security and governance claims.
  • Add Backwards Compatibility and concrete Test Cases (a good-enough start, anyway, we'll update later).
  • Replace the Implementation placeholder with current workstream links.
  • Consolidate unresolved design and deployment work under TODO (this is a rough agent-generated list, but pretty good).
  • Update the quarterly timeline from TWAP to fee-auction pricing.

#1270 didn't have any editor reviews, this is going to need 2 explicit ones on top of my implicit one to land. When we have that, I'll squash down @irenegia's commits to one and then we'll have a base to iterate on in this repo.

Comment thread FIPS/fip-0118.md Outdated
Comment thread FIPS/fip-0118.md Outdated
Comment thread FIPS/fip-0118.md Outdated
@rvagg

rvagg commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

latest tweak just adds code formatting to elements that deserve it, and a little bit more line wrapping treatment for consistency, no material changes

@dannyob dannyob left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor language suggestions/typos. LGTM!

Comment thread FIPS/fip-0118.md Outdated
Comment thread FIPS/fip-0118.md Outdated
Comment thread FIPS/fip-0118.md Outdated
Comment thread FIPS/fip-0118.md Outdated
Comment thread FIPS/fip-0118.md Outdated
Comment thread FIPS/fip-0118.md Outdated
Comment thread FIPS/fip-0118.md Outdated
Comment thread FIPS/fip-0118.md Outdated
Comment thread FIPS/fip-0118.md Outdated
Comment thread FIPS/fip-0118.md Outdated

@jsoares jsoares left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many TODOs, obviously -- and a pending stacked PR -- but this is in great shape for the stage.

Comment thread FIPS/fip-0118.md Outdated
@TippyFlitsUK
TippyFlitsUK merged commit dd5075f into master Aug 5, 2026
1 check passed
@TippyFlitsUK
TippyFlitsUK deleted the rvagg/0118 branch August 5, 2026 14:17
@BigLep BigLep added this to Solstice Aug 19, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in Solstice Aug 19, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Solstice Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants