Make GtCompression Struct visible#62
Merged
vmx merged 1 commit intofilecoin-project:masterfrom May 10, 2025
Merged
Conversation
Contributor
Author
|
The GtCompression algorithms are public but the GtCompressed struct is not. This means that compressed objects cannot be returned or passed into methods. This fix would make the GtCompressed struct public and allow it to be used as intended. |
gabrieliUNC
changed the title
DrPeterVanNostrand
approved these changes
May 7, 2025
Contributor
DrPeterVanNostrand
left a comment
DrPeterVanNostrand
left a comment
There was a problem hiding this comment.
@gabrieliUNC Thanks!
Contributor
|
CI fails, but there's a fix at #63. I'll merge this one even with CI not being fully green as the fix is really trivial and not related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.