Skip to content

fix(ci): commit Cargo.lock pinned to MSRV-compatible deps - #67

Merged
rvagg merged 2 commits into
filecoin-project:masterfrom
gilcu3:fix_ci
Jul 24, 2026
Merged

fix(ci): commit Cargo.lock pinned to MSRV-compatible deps#67
rvagg merged 2 commits into
filecoin-project:masterfrom
gilcu3:fix_ci

Conversation

@gilcu3

@gilcu3 gilcu3 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

This PR is to fix ci.
Currently no Cargo.lock is committed, so when dependencies bump their MSRV beyond 1.63, cargo commands fail. It also adds clippy in one workflow where it was missing for rust 1.63 (similar to what was already done for rustfmt).

If you are open to bump the MSRV I would be happy to do that as well. Users of the crate would probably like to be able to use this crate with the latest rand, and that has MSRV at 1.85 already, so this feels needed by now.

@rvagg

rvagg commented Jul 23, 2026

Copy link
Copy Markdown
Member

lgtm @gilcu3 thanks; would you mind adding --locked in ci.yml so it doesn't fail silently? on each of the test, clippy, doc, and bench invocations in there.

and yeah, updating to 1.85 would be good too (and flushing out pre 0.10 rand!); you're welcome to do that here or in a follow-up PR

@gilcu3

gilcu3 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

lgtm @gilcu3 thanks; would you mind adding --locked in ci.yml so it doesn't fail silently? on each of the test, clippy, doc, and bench invocations in there.

done

and yeah, updating to 1.85 would be good too (and flushing out pre 0.10 rand!); you're welcome to do that here or in a follow-up PR

alright, will do that in a follow-up right after this is merged

@rvagg
rvagg merged commit 05b8dcf into filecoin-project:master Jul 24, 2026
12 checks passed
@rvagg

rvagg commented Jul 24, 2026

Copy link
Copy Markdown
Member

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants