fix(ci): commit Cargo.lock pinned to MSRV-compatible deps - #67
Merged
Conversation
Member
|
lgtm @gilcu3 thanks; would you mind adding and yeah, updating to 1.85 would be good too (and flushing out pre 0.10 rand!); you're welcome to do that here or in a follow-up PR |
Contributor
Author
done
alright, will do that in a follow-up right after this is merged |
rvagg
approved these changes
Jul 24, 2026
Member
|
awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix ci.
Currently no
Cargo.lockis committed, so when dependencies bump their MSRV beyond 1.63, cargo commands fail. It also adds clippy in one workflow where it was missing for rust 1.63 (similar to what was already done for rustfmt).If you are open to bump the MSRV I would be happy to do that as well. Users of the crate would probably like to be able to use this crate with the latest
rand, and that has MSRV at 1.85 already, so this feels needed by now.