chore: bump MSRV to 1.85 - #68
Merged
Merged
Conversation
gilcu3
marked this pull request as ready for review
July 24, 2026 06:37
Member
|
Yes .. but .. https://github.com/filecoin-project/rust-fil-proofs is still on 1.83 and I want to first figure out how much work we're signing up for if we do this right now. This is a good, and right change to do here, but it's a question of whether we can afford to box ourselves into a corner and how much of a work it would be to get out of that corner when we have other things that are on our plate right now. Will get back to you on this asap. |
rvagg
approved these changes
Jul 27, 2026
rvagg
left a comment
rvagg
left a comment
Member
There was a problem hiding this comment.
I had a local copy with an older MSRV .. it turns out the repos where we care about this are at least at 1.93.1; so 1.85 isn't a problem and it would be fine (for us) to go even higher if you wanted to tackle that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It also fixes minor clippy issues after the MSRV bump
@rvagg please take a look when you get a change. I have another branch ready for upgrading
rand_core, but I am holding it until a new compatible version of pairing is released.