Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: precompile actor_type error #1034

Merged
merged 1 commit into from
Jan 13, 2023
Merged

EVM: precompile actor_type error #1034

merged 1 commit into from
Jan 13, 2023

Conversation

mriise
Copy link
Contributor

@mriise mriise commented Jan 13, 2023

return failure instead of empty success on invalid input. This doesn't require test changes because the current tests dont check for exit value, fixed in #1033 .

@mriise mriise requested a review from Stebalien January 13, 2023 01:39
@codecov-commenter
Copy link

Codecov Report

Merging #1034 (196bbc9) into next (b9333d2) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1034      +/-   ##
==========================================
+ Coverage   88.54%   88.66%   +0.11%     
==========================================
  Files         127      127              
  Lines       23683    23684       +1     
==========================================
+ Hits        20970    20999      +29     
+ Misses       2713     2685      -28     
Impacted Files Coverage Δ
actors/evm/src/interpreter/precompiles/fvm.rs 77.55% <100.00%> (+0.15%) ⬆️
actors/market/src/lib.rs 90.38% <0.00%> (-0.22%) ⬇️
actors/miner/src/lib.rs 82.95% <0.00%> (+0.13%) ⬆️
state/src/check.rs 86.35% <0.00%> (+0.26%) ⬆️
...ors/evm/src/interpreter/instructions/arithmetic.rs 81.59% <0.00%> (+0.61%) ⬆️
runtime/src/util/message_accumulator.rs 94.54% <0.00%> (+0.90%) ⬆️
runtime/src/dispatch.rs 100.00% <0.00%> (+1.07%) ⬆️
actors/power/src/lib.rs 84.88% <0.00%> (+1.29%) ⬆️
actors/miner/src/deadline_info.rs 96.62% <0.00%> (+16.85%) ⬆️

@mriise mriise merged commit 93aab43 into next Jan 13, 2023
@mriise mriise deleted the fix/actor-type-error branch January 13, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants