fix: small correctness and quality improvements#1020
Merged
Conversation
Reiers
force-pushed
the
fix/small-correctness-fixes
branch
from
c707b18 to
1b49d19
Compare
- fix(webrpc): discard unused history row id in ClusterTaskHistory scan The SQL query selects both 'id' and 'task_id', but both were scanned into TaskID — the first value was silently overwritten. Use a discard target for the unused column. - fix(alertmanager): prevent duplicate alert output for sealing tasks Sealing tasks with >5 failures were printed twice: once for being a sealing task and once for exceeding the threshold. Use else-if so only one branch fires. - fix(indexing): fix 'failed to to insert' double-word typos In both task_ipni.go and task_pdp_ipni.go error messages. - fix(api): add missing Content-Type headers on JSON responses getSchema, getLayers (config API) and getSectors (sector API) were missing Content-Type: application/json — other handlers in the same files already set it. - fix(cli): 'Command separated' -> 'Comma-separated' in --db-host help Typo in CLI flag description and translation catalog.
Reiers
force-pushed
the
fix/small-correctness-fixes
branch
from
1b49d19 to
00c82ea
Compare
LexLuthr
requested changes
Feb 18, 2026
Contributor
LexLuthr
left a comment
LexLuthr
left a comment
There was a problem hiding this comment.
Requires minor updates.
cmd/curio/internal/translations/locales/zh/messages.gotext.json
Outdated
Show resolved
Hide resolved
LexLuthr
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small one-liner fixes found during codebase audit cross-check.
Changes
Bug fixes
ClusterTaskHistorydouble-scan (web/api/webrpc/cluster.go): The SQL query selects bothid(history row ID) andtask_id, but both were scanned into&t.TaskID— the first value was silently overwritten by the second. Now discards the unusedidcolumn.Duplicate alert for sealing tasks (
alertmanager/alerts.go): Sealing tasks (SDR, TreeD, etc.) with >5 failures produced the same alert line twice — once from the sealing-task check and once from the general >5 threshold check. Changed toelse ifso only one branch fires.Typo fixes
task_ipni.goandtask_pdp_ipni.goerror messages--db-host/--db-host-cqlCLI help text + translation catalogMissing headers
Content-Type: application/jsonadded togetSchema,getLayers(config API), andgetSectors(sector API) — other handlers in the same files already set this header.