Conversation
- Add missing return after 404 in handleDeleteDataSetPiece (would fall through to on-chain tx) - Fix pdptool upload: GET → POST for /pdp/piece/uploads (route is registered as POST) - Fix 'miss-match' → 'mismatch' (2 occurrences in handlers_add.go) - Fix 'failed to to insert' → 'failed to insert' (task_pdp_ipni.go) - Change handleDeleteDataSet stub from 400 → 501 Not Implemented
github-actions
bot
added
the
team/fs-wg
LexLuthr
approved these changes
Feb 18, 2026
ZenGround0
approved these changes
Feb 18, 2026
| client := &http.Client{} | ||
|
|
||
| req, err := http.NewRequest("GET", serviceURL+"/pdp/piece/uploads", nil) | ||
| req, err := http.NewRequest("POST", serviceURL+"/pdp/piece/uploads", nil) |
Contributor
|
@Reiers merge pdpv0 into this and resolve conflict and merge this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from code review of #1013, opened against
pdpv0as requested.Bug fixes
returnafter 404 inhandleDeleteDataSetPiece— without it, a "Piece not found" response falls through to the on-chain transaction call, wasting gaspdptool upload— the/pdp/piece/uploadsroute is registered as POST but pdptool sends GET, so streaming upload initiation is brokenTypos
handlers_add.go)task_pdp_ipni.go)Minor
handleDeleteDataSetstub — changed from 400 Bad Request to 501 Not Implemented (400 implies client error)