fix: FixRawSize CanAccept SQL array cast typo#1034
Closed
Reiers wants to merge 1 commit intofilecoin-project:mainfrom
Closed
fix: FixRawSize CanAccept SQL array cast typo#1034Reiers wants to merge 1 commit intofilecoin-project:mainfrom
Reiers wants to merge 1 commit intofilecoin-project:mainfrom
Conversation
$1::[]bigint is Go slice syntax, not PostgreSQL. Should be $1::bigint[]. Causes 'syntax error at or near "["' on every poll cycle, preventing all FixRawSize tasks from being accepted. Introduced in filecoin-project#855 (improve canAccept() performance) — every other CanAccept rewrite in that PR uses the correct ::bigint[] form; this one file was missed.
Contributor
Author
|
Reopening from upstream branch to trigger CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix PostgreSQL syntax error in
FixRawSize.CanAccept()that breaks all FixRawSize task acceptance on v1.27.3-rc1.Problem
tasks/storage-market/task_fix_rawSize.go:134has:::[]bigintis Go slice syntax, not valid PostgreSQL. The[after::triggers:This fires on every 3s poll cycle, rejecting all FixRawSize tasks. The scheduler (
IAmBored, 60s interval) keeps creating entries up to its cap of 100, none of which can ever be accepted.Fix
Every other
CanAcceptrewrite in the codebase already uses the correct::bigint[]form.Root Cause
Introduced in #855 (improve canAccept() performance) — all other files in that PR use the correct cast; this one was missed.