Skip to content

Integrate gracehttp for zero-downtime HTTP restarts #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
snadrus wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Integrate gracehttp for zero-downtime HTTP restarts #1302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b5adf64
Integrate gracehttp for zero-downtime HTTP restarts
cursoragent Jun 11, 2026
ab639b7
Treat duplicate curio run as graceful restart
cursoragent Jun 11, 2026
e70610d
Add integration test for graceful restart during PDP ping
cursoragent Jun 11, 2026
73313c5
Fix ReadPID unit test to avoid testify dependency
cursoragent Jun 11, 2026
6b16e02
Remove unused strconv import from grace_restart helper
cursoragent Jun 11, 2026
fc6f54b
better restart button
snadrus Jun 11, 2026
43998f3
gen
snadrus Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@ jobs:
target: "./itests/deal_e2e_test.go"
- name: test-itest-dynamic-config
target: "./itests/dyncfg_test.go"
- name: test-itest-grace-restart
target: "./itests/grace_restart_test.go"
- name: test-itest-harmonyDB
target: "./itests/harmonydb_test.go"
- name: test-itest-park-piece
Expand Down
1 change: 1 addition & 0 deletions api/api_curio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ type Curio interface {

Version(context.Context) ([]int, error) //perm:admin
Shutdown(context.Context) error //perm:admin
Restart(context.Context) error //perm:admin
Cordon(context.Context) error //perm:admin
Uncordon(context.Context) error //perm:admin
Info(ctx context.Context) (*ltypes.NodeInfo, error) //perm:read
Expand Down
13 changes: 13 additions & 0 deletions api/proxy_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions apt/curio.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ After=network.target

[Service]
ExecStart=/usr/local/bin/curio run
ExecReload=/bin/kill -USR2 $MAINPID
KillSignal=SIGTERM
Environment=GOLOG_FILE="/var/log/curio/curio.log"
Environment=GOLOG_LOG_FMT="json"
Environment=LD_LIBRARY_PATH="/usr/lib/x86_64-linux-gnu:/usr/lib64"
Expand Down
61 changes: 42 additions & 19 deletions build/openrpc/curio.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L237"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L239"
}
},
{
Expand All @@ -335,7 +335,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L248"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L250"
}
},
{
Expand Down Expand Up @@ -391,7 +391,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L259"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L261"
}
},
{
Expand Down Expand Up @@ -535,7 +535,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L270"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L272"
}
},
{
Expand Down Expand Up @@ -571,7 +571,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L281"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L283"
}
},
{
Expand Down Expand Up @@ -625,7 +625,30 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L292"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L294"
}
},
{
"name": "Filecoin.Restart",
"description": "```go\nfunc (s *CurioStruct) Restart(p0 context.Context) error {\n\tif s.Internal.Restart == nil {\n\t\treturn ErrNotSupported\n\t}\n\treturn s.Internal.Restart(p0)\n}\n```",
"summary": "",
"paramStructure": "by-position",
"params": [],
"result": {
"name": "Null",
"description": "Null",
"schema": {
"type": [
"null"
]
},
"required": true,
"deprecated": false
},
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L305"
}
},
{
Expand All @@ -648,7 +671,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L303"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L316"
}
},
{
Expand Down Expand Up @@ -687,7 +710,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L314"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L327"
}
},
{
Expand Down Expand Up @@ -726,7 +749,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L325"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L338"
}
},
{
Expand Down Expand Up @@ -920,7 +943,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L336"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L349"
}
},
{
Expand Down Expand Up @@ -981,7 +1004,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L347"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L360"
}
},
{
Expand Down Expand Up @@ -1113,7 +1136,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L358"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L371"
}
},
{
Expand Down Expand Up @@ -1247,7 +1270,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L369"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L382"
}
},
{
Expand Down Expand Up @@ -1301,7 +1324,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L380"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L393"
}
},
{
Expand Down Expand Up @@ -1335,7 +1358,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L391"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L404"
}
},
{
Expand Down Expand Up @@ -1389,7 +1412,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L402"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L415"
}
},
{
Expand Down Expand Up @@ -1466,7 +1489,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L413"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L426"
}
},
{
Expand All @@ -1489,7 +1512,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L424"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L437"
}
},
{
Expand Down Expand Up @@ -1527,7 +1550,7 @@
"deprecated": false,
"externalDocs": {
"description": "Github remote link",
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L435"
"url": "https://github.com/filecoin-project/curio/blob/master/api/proxy_gen.go#L448"
}
}
]
Expand Down
1 change: 1 addition & 0 deletions cmd/curio/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ var cliCmd = &cli.Command{
logCmd,
waitApiCmd,
stopCmd,
restartCmd,
cordonCmd,
uncordonCmd,
indexSampleCmd,
Expand Down
Loading
Loading