Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep base layer updated with new config #405

Merged
merged 5 commits into from
Feb 21, 2025
Merged

keep base layer updated with new config #405

merged 5 commits into from
Feb 21, 2025

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Feb 6, 2025

Fixes #368

@LexLuthr LexLuthr requested a review from magik6k February 6, 2025 14:27
magik6k
magik6k reviewed Feb 10, 2025
View reviewed changes
@LexLuthr LexLuthr requested a review from magik6k February 10, 2025 16:42
magik6k
magik6k reviewed Feb 19, 2025
View reviewed changes
magik6k
magik6k reviewed Feb 20, 2025
View reviewed changes
magik6k
magik6k approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nit

@LexLuthr LexLuthr merged commit 65fdf82 into main Feb 21, 2025
31 checks passed
@LexLuthr LexLuthr deleted the fix/base-config branch February 21, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New config defaults don't apply to existing configs
2 participants
@LexLuthr @magik6k