feat: add configurable replication factor for indexstore #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Feb 13, 2025
|
Actually, I would like to know motivation behind this change. Just to clarify, it does not matter to YB even if you make this change. The replication number is controlled by YB master config and not Curio. https://docs.yugabyte.com/stable/api/ycql/ddl_create_keyspace/#semantics Above makes this PR unnecessary. That's why I put that hardcoded value. I must have removed the comment describing above at some point. Or maybe that was in the PR and not code. |
|
In that case, this PR is indeed unnecessary. I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.