Avoiding race condition in batching #413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LexLuthr
reviewed
Feb 17, 2025
There was a problem hiding this comment.
@cryptowhizzard Can you please provide us /root/curio/tasks/seal/poller_commit_msg.go line 115-125? Since you are running customised version, I would like to verify where nil pointer deference is coming from.
SectorNumber can be 0 in the pipeline.
|
Latest main @LexLuthr ... nothing customised here regarding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix :
Feb 12 12:20:07 curioc2b curio[517407]: panic: runtime error: invalid memory address or nil pointer dereference
Feb 12 12:20:07 curioc2b curio[517407]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x18078ff]
Feb 12 12:20:07 curioc2b curio[517407]: goroutine 2771 [running]:
Feb 12 12:20:07 curioc2b curio[517407]: github.com/filecoin-project/curio/tasks/seal.(*SealPoller).pollStartBatchCommitMsg(0xc0003068c0, {0x4906bb0, 0xc00066c050}, {0xc001f44000, 0x844, 0x0?})
Feb 12 12:20:07 curioc2b curio[517407]: #11/root/curio/tasks/seal/poller_commit_msg.go:119 +0x139f
Feb 12 12:20:07 curioc2b curio[517407]: github.com/filecoin-project/curio/tasks/seal.(*SealPoller).poll(0xc0003068c0, {0x4906bb0, 0xc00066c050})
Feb 12 12:20:07 curioc2b curio[517407]: #11/root/curio/tasks/seal/poller.go:267 +0x6c5
Feb 12 12:20:07 curioc2b curio[517407]: github.com/filecoin-project/curio/tasks/seal.(*SealPoller).RunPoller(0xc0003068c0, {0x4906bb0, 0xc00066c050})
Feb 12 12:20:07 curioc2b curio[517407]: #11/root/curio/tasks/seal/poller.go:120 +0x113
Feb 12 12:20:07 curioc2b curio[517407]: created by github.com/filecoin-project/curio/cmd/curio/tasks.addSealingTasks in goroutine 1
Feb 12 12:20:07 curioc2b curio[517407]: #11/root/curio/cmd/curio/tasks/tasks.go:316 +0x2465
Feb 12 12:20:07 curioc2b systemd[1]: curio.service: Main process exited, code=exited, status=2/INVALIDARGUMENT